You are viewing a single comment's thread from:

RE: Steemit Condenser Contributions: Refactoring embedded player code

in HiveDevs4 years ago

be really great if you could support the oEmbed of Wistia too. i can provide more dev details if you can factor that in. thank you.

Sort:  

Only if the embed is an iframe not a JS snippet. But I want to wait until this pull request is approved and merged so that I can implement this with the new architecture

Posted using Partiko iOS

yeah they do iframe as well actually. i'll keep watching out for your posts that mention it then -- https://wistia.com/support/developers for the docs for embedding. just voted for your witness too. great to finally have support for embeds, maybe steem can finally be the social media site we all dreamed of!

hmm, i just looked...

<script src="https://fast.wistia.com/embed/medias/5nep7dgb39.jsonp" async></script><script src="https://fast.wistia.com/assets/external/E-v1.js" async></script><div class="wistia_responsive_padding" style="padding:56.25% 0 0 0;position:relative;"><div class="wistia_responsive_wrapper" style="height:100%;left:0;position:absolute;top:0;width:100%;"><div class="wistia_embed wistia_async_5nep7dgb39 videoFoam=true" style="height:100%;position:relative;width:100%"><div class="wistia_swatch" style="height:100%;left:0;opacity:0;overflow:hidden;position:absolute;top:0;transition:opacity 200ms;width:100%;"><img src="https://fast.wistia.com/embed/medias/5nep7dgb39/swatch" style="filter:blur(5px);height:100%;object-fit:contain;width:100%;" alt="" aria-hidden="true" onload="this.parentNode.style.opacity=1;" /></div></div></div></div>



that's what the embed looks like currently for iframe. it does have a .js script thou -- it's got some great features wistia that would be fantastic to have on steem frontends, like chapters, clickable urls etc. anyway, hope you take a look at it.

This won’t work. It’s a javascript snippet that then generates some HTML markup inside the page but the Condenser won’t allow that.

Posted using Partiko iOS

yeah that's always been the case i think with wistia. shame. guess you have to go and roll your own condenser for that or is that just in general?

Also, please create an issue on GitHub for any new ideas and it will get handled when possible.

https://github.com/steemit/condenser/issues

Posted using Partiko iOS

i don't know how to use that. sorry.