How many different players do you have to support? For things like that definitely seems like a better idea to have it in one spot.
You are viewing a single comment's thread from:
RE: Steemit Condenser Contributions: Refactoring embedded player code
Sort: Trending
Currently:
- dtube
- soundcloud
- threespeak
- twitch
- vimeo
- youtube
And there are two more requests.
LBRY would also be nice to have. Would be nice if we could cross-post video's on Steem and LBRY
Please create an issue on GitHub and it will get handled when possible:
https://github.com/steemit/condenser/issues
Posted using Partiko iOS
Okay, I've added it.
https://github.com/steemit/condenser/issues/3708
I'd be happy to give you some monetary incentive to try and add LBRY support, given that I've only added limited information to the feature request.
Perhaps a $50 bounty? Paid in Steem or whatever other altcoin of choice. Check my Steem savings, so you know I'm good for the money.
And each one was previously being managed in disparate files? O_O sounds like a pain XD
any chance you could support all the different styles of embed for soundcloud? the native one is massive! :)
I would need more details on how to enable each styles. Also same as for my answer to your other comment.
Posted using Partiko iOS
no problem, thanks for replying. there are 3 embed types..
full size, smaller and tiny (this is pro only)
from what i can see the only different on the embed code is the sizing so maybe it just renders a different view based on the size of the iframe?
height="300" and height="166" for the smaller one
the final tiny one is greyed out because i need pro so i can't get the sizing for that -- i've tried in the past to put in the different embed sizing and i always get the default large one.
If it is based on iframe size then you can try an iframe HTML code in the blog post editor and see how it renders. As long as it’s a URL with a supported domain then it will be allowed
Posted using Partiko iOS
hmm, i'll try it again but i think it just reverts back to the full size version..
yeah, the second one should be different but it's not.